You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Jonathan Gray 101791f80f glamor: fix free of uninitialised pointers ... Attempting to run fvwm on a x61/965gm with xserver 1.21.1 with the modesetting driver on OpenBSD/amd64 would cause the xserver to reliably crash. I tracked this down to the free() calls introduced in 2906ee5e4a (d1ca47e124 in branch). clang also warns about this: glamor_program.c:296:13: warning: variable 'vs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] glamor_program.c:290:9: warning: variable 'vs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] glamor_program.c:288:9: warning: variable 'vs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] glamor_program.c:277:13: warning: variable 'vs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] glamor_program.c:296:13: warning: variable 'fs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] glamor_program.c:290:9: warning: variable 'fs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] glamor_program.c:288:9: warning: variable 'fs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] glamor_program.c:277:13: warning: variable 'fs_prog_string' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] Signed-off-by: Jonathan Gray <jsg@jsg.id.au> Reviewed-by: Olivier Fourdan <ofourdan@redhat.com> Fixes: 2906ee5e4 ("glamor: Fix leak in glamor_build_program()") (cherry picked from commit 5ac6319776)		3 years ago
..
Makefile.am	glamor: Implement PixmapFromBuffers and BuffersFromPixmap	7 years ago
glamor.c	glamor: Fix handling of 1-bit pixmaps	3 years ago
glamor.h	Fix spelling/wording issues	4 years ago
glamor_addtraps.c	glamor: Remove _nf rendering functions	10 years ago
glamor_composite_glyphs.c	glamor: add glamor_glsl_has_ints wrapper	3 years ago
glamor_compositerects.c	glamor: fix wrong offset on composite rectangles	9 years ago
glamor_context.h	glamor: Replace glamor_get/put_context() with just glamor_make_current().	11 years ago
glamor_copy.c	glamor: Propagate glamor_prepare_access failures in copy helpers	6 years ago
glamor_core.c	glamor: Stop tracking the screen_fbo.	8 years ago
glamor_dash.c	glamor: Fix dashed line rendering.	8 years ago
glamor_debug.h	glamor: Remove the "delayed fallback" code.	8 years ago
glamor_egl.c	Revert "glamor: Enable modifier support for xfree86 too"	3 years ago
glamor_egl.h	glamor/xwayland: Define EGL_NO_X11	5 years ago
glamor_egl_ext.h	glamor: Implement PixmapFromBuffers and BuffersFromPixmap	7 years ago
glamor_egl_stubs.c	glamor: Unbreak glamor_fd_from_pixmap()	7 years ago
glamor_eglmodule.c	glamor: Bump version to 1.0.1 to signal depth 30 support.	7 years ago
glamor_fbo.c	glamor: make sure the correct FBO is cleared	5 years ago
glamor_font.c	glamor: add glamor_glsl_has_ints wrapper	3 years ago
glamor_font.h	glamor: store old fonts in double width textures.	9 years ago
glamor_glx.c	glamor: Do the same MakeCurrent(None) for GLX as we do for EGL.	11 years ago
glamor_glyphblt.c	glamor: Check glamor_set_destination_drawable() return value	8 years ago
glamor_gradient.c	Fix spelling/wording issues	4 years ago
glamor_image.c	glamor: Avoid software fallback for planemasked ZPixmap GetImage	8 years ago
glamor_largepixmap.c	Fix spelling/wording issues	4 years ago
glamor_lines.c	glamor: Check glamor_set_destination_drawable() return value	8 years ago
glamor_picture.c	glamor: Introduce a central place for our pixmap format/type handling.	6 years ago
glamor_pixmap.c	glamor: Switch the gl_flavor to a boolean is_gles.	6 years ago
glamor_points.c	glamor: Check glamor_set_destination_drawable() return value	8 years ago
glamor_prepare.c	glamor: Fix a compiler warning since the recent OOM fixes.	6 years ago
glamor_prepare.h	glamor: Replace fallback preparation code	11 years ago
glamor_priv.h	glamor: Fix handling of 1-bit pixmaps	3 years ago
glamor_program.c	glamor: fix free of uninitialised pointers	3 years ago
glamor_program.h	glamor: Add support for CA rendering in a single pass.	9 years ago
glamor_rects.c	glamor: add glamor_glsl_has_ints wrapper	3 years ago
glamor_render.c	glamor: Fix handling of 1-bit pixmaps	3 years ago
glamor_segs.c	glamor: Check glamor_set_destination_drawable() return value	8 years ago
glamor_spans.c	glamor: add glamor_glsl_has_ints wrapper	3 years ago
glamor_sync.c	glamor: Make glamor_sync_init work with --disable-xshmfence	8 years ago
glamor_text.c	glamor: Translate solid text background region after clipping	8 years ago
glamor_transfer.c	glamor: Introduce a central place for our pixmap format/type handling.	6 years ago
glamor_transfer.h	glamor: Introduce a central place for our pixmap format/type handling.	6 years ago
glamor_transform.c	glamor: Fix more fallback paths with non-GXcopy rop with GLES	6 years ago
glamor_transform.h	glamor: glamor_set_destination_drawable() can fail	8 years ago
glamor_trapezoid.c	glamor: Remove _nf rendering functions	10 years ago
glamor_triangles.c	glamor: Remove _nf rendering functions	10 years ago
glamor_utils.c	Convert glamor & glx to new *allocarray functions	10 years ago
glamor_utils.h	glamor: add EXT_gpu_shader4 support	3 years ago
glamor_vbo.c	Fix spelling/wording issues	4 years ago
glamor_window.c	glamor: Drop tracking of the last picture attached to pixmaps.	10 years ago
glamor_xv.c	Consolidate fourcc.h	4 years ago
meson.build	glamor: Implement GetSupportedModifiers	7 years ago