mirror
/
re3
Archived
Code Issues 124 Pull Requests 24 Projects Releases Wiki Activity

Labels Milestones

New Pull Request

(lcs) reversed CScrollBar #1297

Open
asm95 wants to merge 2 commits from asm95/lcs-scrollbar into lcs
pull from: asm95/lcs-scrollbar
merge into: mirror:lcs
Conversation 0 Commits 2 Files Changed 1

2 Commits (master)

Author SHA1 Message Date
asm95 e0601296a9 [lcs] corrections for CScrollBar (code style) 
Changes were made to be compliant with the coding style:
- All floats should be explicit by specifying "f" suffix so compiler
doesn't use double as default
- Changed the conditional order to be more clear about what the
"if" chain trying to achieve

Thanks Nick007J
 3 years ago
asm95 ee9e8bf11e [lcs] reversed CScrollBar 
Summary of changes compared to VC below:

- Now we have 12 scroll bars instead of one
- Copied the enum names from re3: d0404cbdb7/src/renderer/Fluff.cpp (L80)
 + todo: maybe check if the names still make sense

- CScrollBar::Init ~ no changes
- CScrollBar::Update ~ added many hard-coded text
- CScrollBar::Render ~ minor changes on corona coordinates formula

- CMovingThings::Init ~ initialize the 12 scroll bars with a loop
- CMovingThings::Update, CMovingThings::Render ~ no changes
- CMovingThings::Shutdown ~ iterate  over aScrollBars to
 disable visibility

 Other notes:

 - Android and PSP CScrollBar logic is identical
 3 years ago