mirror
/
re3
Archived
Code Issues 124 Pull Requests 24 Projects Releases Wiki Activity

Labels Milestones

(lcs) reversed CScrollBar #1297

Open
asm95 wants to merge 2 commits from asm95/lcs-scrollbar into lcs
pull from: asm95/lcs-scrollbar
merge into: mirror:lcs
Conversation 0 Commits 2 Files Changed 1
asm95 commented 3 years ago (Migrated from github.com)

Summary of changes compared to VC

  • Now we have 12 scroll bars instead of one

  • Copied the enum names from re3: d0404cbdb7/src/renderer/Fluff.cpp (L80)

  • CScrollBar::Init ~ no changes

  • CScrollBar::Update ~ added many hard-coded text

  • CScrollBar::Render ~ minor changes on corona coordinates formula

  • CMovingThings::Init ~ initialize the 12 scroll bars now

  • CMovingThings::Update, CMovingThings::Render ~ no changes

  • CMovingThings::Shutdown ~ iterate over aScrollBars to disable visibility

Showcase

The following picture reveals Toni observing the blue text propaganda. In previous reLCS version, this text was not shown.

Other notes

  • Android and PSP CScrollBar logic is identical
  • Issue: the text scrolls too fast. This might be related to the FPS in PC.
### Summary of changes compared to VC - Now we have 12 scroll bars instead of one - Copied the `enum` names from re3: https://github.com/GTAmodding/re3/blob/d0404cbdb77bd82abf578ce28093990db94743f2/src/renderer/Fluff.cpp#L80 - `CScrollBar::Init` ~ no changes - `CScrollBar::Update` ~ added many hard-coded text - `CScrollBar::Render` ~ minor changes on corona coordinates formula - `CMovingThings::Init` ~ initialize the 12 scroll bars now - `CMovingThings::Update`, `CMovingThings::Render` ~ no changes - `CMovingThings::Shutdown` ~ iterate over aScrollBars to disable visibility ### Showcase The following picture reveals Toni observing the blue text propaganda. In previous `reLCS` version, this text was not shown. <p align="center"><img width="50%" src="https://user-images.githubusercontent.com/13230288/129466133-e52c0436-1e02-4127-9f04-189d6015ee20.png"></p> ### Other notes - Android and PSP CScrollBar logic is identical - Issue: the text scrolls too fast. This might be related to the FPS in PC.
Nick007J (Migrated from github.com) reviewed 3 years ago
src/renderer/Fluff.cpp
Nick007J (Migrated from github.com) commented 3 years ago

Floats need to have f suffix, and also this needs to be in different order:

if (CWeather::Foggyness > 0.5f)
    m_pMessage = ...
else if (CWeather::WetRoads > 0.5f)
    m_pMessage = ...
else
    m_pMessage = ...
Floats need to have `f` suffix, and also this needs to be in different order: ``` if (CWeather::Foggyness > 0.5f) m_pMessage = ... else if (CWeather::WetRoads > 0.5f) m_pMessage = ... else m_pMessage = ... ```
asm95 (Migrated from github.com) reviewed 3 years ago
src/renderer/Fluff.cpp
asm95 (Migrated from github.com) commented 3 years ago

Got the corrections in check. Thanks for the suggestions 😺

Got the corrections in check. Thanks for the suggestions 😺
Nick007J (Migrated from github.com) reviewed 3 years ago
src/renderer/Fluff.cpp
Nick007J (Migrated from github.com) commented 3 years ago

Looks like all digits originally were at most 3 digits after decimal point, e.g. -591.048f. Same applies to all initialization here.

Looks like all digits originally were at most 3 digits after decimal point, e.g. -591.048f. Same applies to all initialization here.
src/renderer/Fluff.cpp
Nick007J (Migrated from github.com) commented 3 years ago

This was a switch. If it was taken from re3, then it needs to be fixed as well :P

This was a switch. If it was taken from re3, then it needs to be fixed as well :P
src/renderer/Fluff.cpp
Nick007J (Migrated from github.com) commented 3 years ago

Random glitches part blow has changed, check it out

Random glitches part blow has changed, check it out
asm95 (Migrated from github.com) reviewed 3 years ago
src/renderer/Fluff.cpp
asm95 (Migrated from github.com) commented 3 years ago

Oh, damn that's right... Will change that to a switch(m_Type){...} statement. Yeah, I followed miami's branch but forgot that was a switch in IDA and also in master branch.

Oh, damn that's right... Will change that to a `switch(m_Type){...}` statement. Yeah, I followed [miami](https://github.com/GTAmodding/re3/blob/miami/src/renderer/Fluff.cpp#L672)'s branch but forgot that was a `switch` in IDA and also in [master](https://github.com/GTAmodding/re3/blob/master/src/renderer/Fluff.cpp#L361) branch.
asm95 (Migrated from github.com) reviewed 3 years ago
src/renderer/Fluff.cpp
asm95 (Migrated from github.com) commented 3 years ago

Those extra digits were usually appearing in IDA. Anyway, I'll remove those cases with more than 3 decimal digits.

Those extra digits were usually appearing in IDA. Anyway, I'll remove those cases with more than 3 decimal digits.
This repo is archived. You cannot comment on pull requests.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something isn't working   
documentation

need for improvement or additions to documentation   
duplicate

This issue or pull request already exists   
enhancement

New feature or request   
fork idea
   
good first issue

Good for newcomers   
help wanted

Extra attention is needed   
help-desk
   
invalid

This doesn't seem right   
is it bug or not?
   
lcs

reLCS related   
linux
   
math
   
miami

reVC related   
not our problem
   
openal
   
performance
   
question

Further information is requested   
vanilla

Issues happening in original game   
wontfix

This will not be worked on
No Label
bug
documentation
duplicate
enhancement
fork idea
good first issue
help wanted
help-desk
invalid
is it bug or not?
lcs
linux
math
miami
not our problem
openal
performance
question
vanilla
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mirror/re3#1297
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'asm95/lcs-scrollbar'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes