mirror of https://gitlab.com/qemu-project/qemu
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
![]() tcg_region_init() calls one of qemu_mprotect_rwx(), qemu_mprotect_rw(), and mprotect(), then reports failure with error_setg_errno(&error_fatal, errno, ...). The use of &error_fatal is undesirable. qapi/error.h advises: * Please don't error_setg(&error_fatal, ...), use error_report() and * exit(), because that's more obvious. The use of errno is wrong. qemu_mprotect_rwx() and qemu_mprotect_rw() wrap around qemu_mprotect__osdep(). qemu_mprotect__osdep() calls mprotect() on POSIX, VirtualProtect() on Windows, and reports failure with error_report(). VirtualProtect() doesn't set errno. mprotect() does, but error_report() may clobber it. Fix tcg_region_init() to report errors only when it calls mprotect(), and rely on qemu_mprotect_rwx()'s and qemu_mprotect_rw()'s error reporting otherwise. Use error_report(), not error_setg(). Fixes: |
3 weeks ago | |
---|---|---|
.. | ||
aarch64 | 4 weeks ago | |
arm | 4 weeks ago | |
i386 | 2 months ago | |
loongarch64 | 5 months ago | |
mips | 5 months ago | |
ppc | 5 months ago | |
riscv | 4 months ago | |
s390x | 5 months ago | |
sparc64 | 5 months ago | |
tci | 6 months ago | |
debuginfo.c | 2 years ago | |
meson.build | 5 months ago | |
optimize.c | 4 weeks ago | |
perf.c | 5 months ago | |
region.c | 3 weeks ago | |
tcg-common.c | 9 months ago | |
tcg-has.h | 6 months ago | |
tcg-internal.h | 6 months ago | |
tcg-op-gvec.c | 4 months ago | |
tcg-op-ldst.c | 2 months ago | |
tcg-op-vec.c | 9 months ago | |
tcg-op.c | 6 months ago | |
tcg.c | 4 weeks ago | |
tci.c | 6 months ago |