You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/target/ppc/translate
Fabiano Rosas 8bded2e73e target/ppc: Fix lxvx/stxvx facility check
The XT check for the lxvx/stxvx instructions is currently
inverted. This was introduced during the move to decodetree.

>From the ISA:
  Chapter 7. Vector-Scalar Extension Facility
  Load VSX Vector Indexed X-form

  lxvx XT,RA,RB
  if TX=0 & MSR.VSX=0 then VSX_Unavailable()
  if TX=1 & MSR.VEC=0 then Vector_Unavailable()
  ...
  Let XT be the value 32×TX + T.

The code currently does the opposite:

    if (paired || a->rt >= 32) {
        REQUIRE_VSX(ctx);
    } else {
        REQUIRE_VECTOR(ctx);
    }

This was already fixed for lxv/stxv at commit "2cc0e449d1 (target/ppc:
Fix lxv/stxv MSR facility check)", but the indexed forms were missed.

Cc: qemu-stable@nongnu.org
Fixes: 70426b5bb7 ("target/ppc: moved stxvx and lxvx from legacy to decodtree")
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Message-ID: <20240911141651.6914-1-farosas@suse.de>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
2 months ago
..
bhrb-impl.c.inc target/ppc: Add clrbhrb and mfbhrbe instructions 7 months ago
branch-impl.c.inc target/ppc: Add recording of taken branches to BHRB 7 months ago
dfp-impl.c.inc tcg: Rename cpu_env to tcg_env 1 year ago
fixedpoint-impl.c.inc target/ppc: Move logical fixed-point instructions to decodetree. 7 months ago
fp-impl.c.inc target/ppc: Move floating-point arithmetic instructions to decodetree. 7 months ago
fp-ops.c.inc target/ppc: Move floating-point arithmetic instructions to decodetree. 7 months ago
misc-impl.c.inc target/ppc: Implement attn instruction on BookS 64-bit processors 7 months ago
processor-ctrl-impl.c.inc target/ppc: add SMT support to msgsnd broadcast 7 months ago
spe-impl.c.inc tcg: Rename cpu_env to tcg_env 1 year ago
spe-ops.c.inc
storage-ctrl-impl.c.inc target/ppc: Fix broadcast tlbie synchronisation 7 months ago
vmx-impl.c.inc target/ppc: Update VMX storage access insns to use tcg_gen_qemu_ld/st_i128. 4 months ago
vmx-ops.c.inc target/ppc: Move VMX integer add/sub saturate insns to decodetree. 4 months ago
vsx-impl.c.inc target/ppc: Fix lxvx/stxvx facility check 2 months ago
vsx-ops.c.inc target/ppc: Move VSX fp compare insns to decodetree. 4 months ago