You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/include/block
Klaus Jensen 3050b34921 hw/nvme: fix namespace atomic parameter setup
Coverity complains about a possible copy-paste error in the verification
of the namespace atomic parameters (CID 1642811). While the check is
correct, the code (and the intention) is unclear.

Fix this by reworking how the parameters are verified. Peter also
identified that the realize function was not correctly erroring out if
parameters were misconfigured, so fix that too.

Lastly, change the error messages to be more describing.

Coverity: CID 1642811
Fixes: bce51b8370 ("hw/nvme: add atomic boundary support")
Fixes: 3b41acc962 ("hw/nvme: enable ns atomic writes")
Reviewed-by: Jesper Wendel Devantier <foss@defmacro.it>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
1 week ago
..
accounting.h block: enable stats-intervals for storage devices 1 month ago
aio-wait.h system/cpus: rename qemu_mutex_lock_iothread() to bql_lock() 2 years ago
aio.h block: Note on aio_co_wake use if not yet yielding 2 weeks ago
aio_task.h block: Remove unused aio_task_pool_empty 1 year ago
block-common.h block: Expand block status mode from bool to flags 7 months ago
block-copy.h copy-before-write: allow specifying minimum cluster size 1 year ago
block-global-state.h block: Allow drivers to control protocol prefix at creation 3 weeks ago
block-hmp-cmds.h include/block: Untangle inclusion loops 3 years ago
block-io.h block: mark bdrv_drained_begin() and friends as GRAPH_UNLOCKED 6 months ago
block.h include/block: Untangle inclusion loops 3 years ago
block_backup.h include/block: Untangle inclusion loops 3 years ago
block_int-common.h block: Note in which AioContext AIO CBs are called 2 weeks ago
block_int-global-state.h mirror: Drop redundant zero_target parameter 7 months ago
block_int-io.h block: make bdrv_co_parent_cb_resize() a proper IO API function 1 month ago
block_int.h include/block: Untangle inclusion loops 3 years ago
blockjob.h blockjob: mark block_job_remove_all_bdrv() as GRAPH_UNLOCKED 5 months ago
blockjob_int.h block: Mark block_job_add_bdrv() GRAPH_WRLOCK 2 years ago
dirty-bitmap.h block: Mark bdrv_*_dirty_bitmap() and callers GRAPH_RDLOCK 3 years ago
export.h block/export: Add option to allow export of inactive nodes 10 months ago
fuse.h fuse: Allow exporting BDSs via FUSE 5 years ago
graph-lock.h block: add bdrv_graph_wrlock_drained() convenience wrapper 5 months ago
nbd.h block: replace TABs with space 3 weeks ago
nvme.h hw/nvme: fix namespace atomic parameter setup 1 week ago
qapi.h qemu-img info: Optionally show block limits 1 month ago
qdict.h qapi: Move include/qapi/qmp/ to include/qobject/ 10 months ago
raw-aio.h block/io_uring: use aio_add_sqe() 3 weeks ago
replication.h replication: move include out of root directory 5 years ago
reqlist.h block/reqlist: add reqlist_wait_all() 4 years ago
snapshot.h block/snapshot: mark bdrv_all_delete_snapshot() as GRAPH_UNLOCKED 5 months ago
thread-pool.h thread-pool: Implement generic (non-AIO) pool support 9 months ago
throttle-groups.h block/throttle-groups: Use ThrottleDirection instread of bool is_write 2 years ago
ufs.h hw/ufs: Add temperature event notification support 9 months ago
write-threshold.h block: Clean up includes 3 years ago