mirror of https://gitlab.com/qemu-project/qemu
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
4dec497264
In the xlnx-versal-cframe-reg device we create a FIFO in
instance_init but don't destroy it on deinit, causing ASAN
to report a leak in the device-introspect-test:
Direct leak of 400 byte(s) in 1 object(s) allocated from:
#0 0x5aded4d54e23 in malloc (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/qemu-system-aarch64+0x24ffe23) (BuildId: 9f1e6c53fecd904ba5fc1f521d7da080a0e4103b)
#1 0x71fbfac9bb09 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x62b09) (BuildId: 1eb6131419edb83b2178b682829a6913cf682d75)
#2 0x5aded850059d in fifo8_create /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/../../util/fifo8.c:27:18
#3 0x5aded582b9e4 in fifo32_create /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/include/qemu/fifo32.h:35:5
#4 0x5aded582b326 in cframe_reg_init /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/../../hw/misc/xlnx-versal-cframe-reg.c:693:5
Similarly, we don't clean up the g_tree we create:
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0x5aded4d54e23 in malloc (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/qemu-system-aarch64+0x24ffe23) (BuildId: 9f1e6c5
3fecd904ba5fc1f521d7da080a0e4103b)
#1 0x71fbfac9bb09 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x62b09) (BuildId: 1eb6131419edb83b2178b682829a6913cf682d75)
#2 0x71fbfaccc799 in g_tree_new_full (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x93799) (BuildId: 1eb6131419edb83b2178b682829a6913cf682d7
5)
#3 0x5aded582b21a in cframe_reg_init /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-asan/../../hw/misc/xlnx-versal-cframe-reg.c:691:18
Add an instance_finalize method to clean up what we
allocated in instance_init.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com>
Message-ID: <20250826174956.3010274-2-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
6 days ago | |
|---|---|---|
| .. | ||
| macio | 5 months ago | |
| Kconfig | 2 months ago | |
| a9scu.c | 5 months ago | |
| allwinner-a10-ccm.c | 5 months ago | |
| allwinner-a10-dramc.c | 5 months ago | |
| allwinner-cpucfg.c | 5 months ago | |
| allwinner-h3-ccu.c | 5 months ago | |
| allwinner-h3-dramc.c | 5 months ago | |
| allwinner-h3-sysctrl.c | 5 months ago | |
| allwinner-r40-ccu.c | 5 months ago | |
| allwinner-r40-dramc.c | 5 months ago | |
| allwinner-sid.c | 5 months ago | |
| allwinner-sramc.c | 5 months ago | |
| applesmc.c | 5 months ago | |
| arm11scu.c | 5 months ago | |
| arm_integrator_debug.c | 5 years ago | |
| arm_l2x0.c | 5 months ago | |
| arm_sysctl.c | 5 months ago | |
| armsse-cpu-pwrctrl.c | 5 months ago | |
| armsse-cpuid.c | 5 months ago | |
| armsse-mhu.c | 5 months ago | |
| armv7m_ras.c | 5 months ago | |
| aspeed_hace.c | 3 months ago | |
| aspeed_i3c.c | 5 months ago | |
| aspeed_lpc.c | 5 months ago | |
| aspeed_peci.c | 5 months ago | |
| aspeed_sbc.c | 5 months ago | |
| aspeed_scu.c | 2 months ago | |
| aspeed_sdmc.c | 2 months ago | |
| aspeed_sli.c | 5 months ago | |
| aspeed_xdma.c | 5 months ago | |
| auxbus.c | 5 months ago | |
| avr_power.c | 5 months ago | |
| axp2xx.c | 5 months ago | |
| bcm2835_cprman.c | 5 months ago | |
| bcm2835_mbox.c | 5 months ago | |
| bcm2835_mphi.c | 5 months ago | |
| bcm2835_powermgt.c | 5 months ago | |
| bcm2835_property.c | 5 months ago | |
| bcm2835_rng.c | 5 months ago | |
| bcm2835_thermal.c | 5 months ago | |
| debugexit.c | 5 months ago | |
| djmemc.c | 5 months ago | |
| eccmemctl.c | 5 months ago | |
| edu.c | 5 months ago | |
| empty_slot.c | 5 months ago | |
| exynos4210_clk.c | 5 months ago | |
| exynos4210_pmu.c | 5 months ago | |
| exynos4210_rng.c | 5 months ago | |
| grlib_ahb_apb_pnp.c | 5 months ago | |
| i2c-echo.c | 5 months ago | |
| imx6_ccm.c | 5 months ago | |
| imx6_src.c | 5 months ago | |
| imx6ul_ccm.c | 5 months ago | |
| imx7_ccm.c | 5 months ago | |
| imx7_gpr.c | 5 months ago | |
| imx7_snvs.c | 5 months ago | |
| imx7_src.c | 5 months ago | |
| imx8mp_analog.c | 5 months ago | |
| imx8mp_ccm.c | 5 months ago | |
| imx25_ccm.c | 5 months ago | |
| imx31_ccm.c | 5 months ago | |
| imx_ccm.c | 4 years ago | |
| imx_rngc.c | 5 months ago | |
| iosb.c | 5 months ago | |
| iotkit-secctl.c | 5 months ago | |
| iotkit-sysctl.c | 5 months ago | |
| iotkit-sysinfo.c | 5 months ago | |
| ivshmem-flat.c | 2 months ago | |
| ivshmem-pci.c | 2 months ago | |
| lasi.c | 5 months ago | |
| led.c | 5 months ago | |
| mac_via.c | 5 months ago | |
| max78000_aes.c | 2 months ago | |
| max78000_gcr.c | 2 months ago | |
| max78000_icc.c | 2 months ago | |
| max78000_trng.c | 2 months ago | |
| mchp_pfsoc_dmc.c | 5 months ago | |
| mchp_pfsoc_ioscb.c | 5 months ago | |
| mchp_pfsoc_sysreg.c | 4 months ago | |
| meson.build | 2 months ago | |
| mips_cmgcr.c | 5 months ago | |
| mips_cpc.c | 5 months ago | |
| mips_itu.c | 5 months ago | |
| mos6522.c | 5 months ago | |
| mps2-fpgaio.c | 5 months ago | |
| mps2-scc.c | 5 months ago | |
| msf2-sysreg.c | 5 months ago | |
| npcm7xx_mft.c | 5 months ago | |
| npcm7xx_pwm.c | 5 months ago | |
| npcm7xx_rng.c | 5 months ago | |
| npcm_clk.c | 5 months ago | |
| npcm_gcr.c | 5 months ago | |
| nrf51_rng.c | 5 months ago | |
| omap_clk.c | 4 months ago | |
| pc-testdev.c | 5 months ago | |
| pci-testdev.c | 4 months ago | |
| pvpanic-isa.c | 5 months ago | |
| pvpanic-mmio.c | 5 months ago | |
| pvpanic-pci.c | 5 months ago | |
| pvpanic.c | 9 months ago | |
| sbsa_ec.c | 5 months ago | |
| sifive_e_aon.c | 5 months ago | |
| sifive_e_prci.c | 4 years ago | |
| sifive_test.c | 9 months ago | |
| sifive_u_otp.c | 5 months ago | |
| sifive_u_prci.c | 5 months ago | |
| slavio_misc.c | 5 months ago | |
| stm32_rcc.c | 3 months ago | |
| stm32f2xx_syscfg.c | 5 months ago | |
| stm32f4xx_exti.c | 5 months ago | |
| stm32f4xx_syscfg.c | 5 months ago | |
| stm32l4x5_exti.c | 5 months ago | |
| stm32l4x5_rcc.c | 5 months ago | |
| stm32l4x5_syscfg.c | 5 months ago | |
| trace-events | 4 months ago | |
| trace.h | 5 years ago | |
| tz-mpc.c | 5 months ago | |
| tz-msc.c | 5 months ago | |
| tz-ppc.c | 5 months ago | |
| unimp.c | 5 months ago | |
| virt_ctrl.c | 5 months ago | |
| vmcoreinfo.c | 5 months ago | |
| xlnx-cfi-if.c | 2 years ago | |
| xlnx-versal-cframe-reg.c | 6 days ago | |
| xlnx-versal-cfu.c | 5 months ago | |
| xlnx-versal-crl.c | 5 months ago | |
| xlnx-versal-pmc-iou-slcr.c | 5 months ago | |
| xlnx-versal-trng.c | 5 months ago | |
| xlnx-versal-xramc.c | 5 months ago | |
| xlnx-zynqmp-apu-ctrl.c | 5 months ago | |
| xlnx-zynqmp-crf.c | 5 months ago | |
| zynq_slcr.c | 5 months ago | |