You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/hw/display
Philippe Mathieu-Daudé 302075f85e hw/display/vga: Do not reset 'big_endian_fb' in vga_common_reset()
The 'pci-vga' device allow setting a 'big-endian-framebuffer'
property since commit 3c2784fc86 ("vga: Expose framebuffer
byteorder as a QOM property"). Similarly, the 'virtio-vga'
device since commit 8be61ce2ce ("virtio-vga: implement
big-endian-framebuffer property").

Both call vga_common_reset() in their reset handler, respectively
pci_secondary_vga_reset() and virtio_vga_base_reset_hold(), which
reset 'big_endian_fb', overwritting the property. This is not
correct: the hardware is expected to keep its configured
endianness during resets.

Move 'big_endian_fb' assignment from vga_common_reset() to
vga_common_init() which is called once when the common VGA state
is initialized.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Message-Id: <20241129101721.17836-2-philmd@linaro.org>
1 day ago
..
Kconfig * pc: Add a description for the i8042 property 2 months ago
acpi-vga-stub.c acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors 2 years ago
acpi-vga.c acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors 2 years ago
artist.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
ati.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
ati_2d.c hw/display/ati: allow compiling without PIXMAN 1 year ago
ati_dbg.c ati-vga: Add 30 bit palette access register 1 year ago
ati_int.h ati-vga: Implement fallback for pixman routines 1 year ago
ati_regs.h ati-vga: Add 30 bit palette access register 1 year ago
bcm2835_fb.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
bochs-display.c hw/display: Constify VMState 11 months ago
cg3.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
cirrus_vga.c vga: implement horizontal pel panning in graphics modes 11 months ago
cirrus_vga_internal.h
cirrus_vga_isa.c display: include dependencies explicitly 2 years ago
cirrus_vga_rop.h
cirrus_vga_rop2.h
dm163.c hw/display: Fix mirrored output in dm163 3 months ago
dpcd.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
edid-generate.c
edid-region.c
exynos4210_fimd.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
framebuffer.c
framebuffer.h
g364fb.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
i2c-ddc.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
jazz_led.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
macfb.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
meson.build hw/display: Remove omap_dss 2 months ago
next-fb.c hw/display/next-fb: Fix comment typo 2 years ago
omap_lcdc.c hw/arm/omap: Drop useless casts from void * to pointer 2 years ago
pl110.c hw/display/pl110: Pass frame buffer memory region as link property 9 months ago
pl110_template.h
qxl-logger.c hw/display/qxl: Pass requested buffer size to qxl_phys2virt() 2 years ago
qxl-render.c ui/console: Remove dpy_cursor_define_supported() 5 months ago
qxl.c hw/qxl: fix -Werror=maybe-uninitialized false-positives 2 months ago
qxl.h Replace "iothread lock" with "BQL" in comments 11 months ago
ramfb-standalone.c hw/display: Constify VMState 11 months ago
ramfb-stubs.c ramfb: move stubs out of stubs/ 8 months ago
ramfb.c hw/display: Constify VMState 11 months ago
sii9022.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
sm501.c hw/char: Extract serial-mm 2 months ago
ssd0303.c hw/display: Constify VMState 11 months ago
ssd0323.c hw/display: Constify VMState 11 months ago
tcx.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
trace-events virtio-gpu: Support suspension of commands processing 1 month ago
trace.h
vga-access.h
vga-helpers.h vga: optimize horizontal pel panning in 256-color modes 11 months ago
vga-isa.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
vga-mmio.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
vga-pci.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
vga.c hw/display/vga: Do not reset 'big_endian_fb' in vga_common_reset() 1 day ago
vga_int.h display: remove GraphicHwOps from typedefs.h 7 months ago
vga_regs.h vga: sort-of implement word and double-word access modes 11 months ago
vhost-user-gpu-pci.c modules: introduces module_kconfig directive 3 years ago
vhost-user-gpu.c virtio: Allow .get_vhost() without vhost_started 3 months ago
vhost-user-vga.c modules: introduces module_kconfig directive 3 years ago
virtio-dmabuf.c hw/display: fix memleak from virtio_add_resource 1 year ago
virtio-gpu-base.c Fix bugs when VM shutdown with virtio-gpu unplugged 11 months ago
virtio-gpu-gl.c virtio-gpu: Support Venus context 1 month ago
virtio-gpu-pci-gl.c modules: introduces module_kconfig directive 3 years ago
virtio-gpu-pci-rutabaga.c virtio-gpu-rutabaga: Add empty interface to fix arm64 crash 1 year ago
virtio-gpu-pci.c virtio-gpu: hostmem 1 year ago
virtio-gpu-rutabaga.c virtio-gpu-rutabaga.c: override resource_destroy method 10 months ago
virtio-gpu-udmabuf-stubs.c
virtio-gpu-udmabuf.c ui/console: Use qemu_dmabuf_new() and free() helpers instead 7 months ago
virtio-gpu-virgl.c hw/display: factor out the scanout blob to fb conversion 2 weeks ago
virtio-gpu.c hw/display: check frame buffer can hold blob 2 weeks ago
virtio-vga-gl.c modules: introduces module_kconfig directive 3 years ago
virtio-vga-rutabaga.c gfxstream + rutabaga: add initial support for gfxstream 1 year ago
virtio-vga.c hw, target: Add ResetType argument to hold and exit phase methods 7 months ago
virtio-vga.h hw/display/virtio-vga: Convert TYPE_VIRTIO_VGA_BASE to 3-phase reset 2 years ago
vmware_vga.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago
xenfb.c ui+display: rename is_buffer_shared() -> surface_is_allocated() 6 months ago
xlnx_dp.c hw: Use device_class_set_legacy_reset() instead of opencoding 3 months ago