You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/hw/core
Fiona Ebner eef2dd03f9 hw/core/qdev-properties-system: Add missing return in set_drive_helper()
Currently, changing the 'drive' property of e.g. a scsi-hd object will
result in an assertion failure if the aio context of the block node
it's replaced with doesn't match the current aio context:

> bdrv_replace_child_noperm: Assertion `bdrv_get_aio_context(old_bs) ==
> bdrv_get_aio_context(new_bs)' failed.

The problematic scenario is already detected, but a 'return' statement
was missing.

Cc: qemu-stable@nongnu.org
Fixes: d1a58c176a ("qdev: allow setting drive property for realized device")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20250523070211.280498-1-f.ebner@proxmox.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
3 weeks ago
..
Kconfig
bus.c qom: Make InterfaceInfo[] uses const 2 months ago
clock-vmstate.c
clock.c qom: Have class_init() take a const data argument 2 months ago
cpu-common.c hw/core/cpu-common: Don't init gdbstub until cpu_exec_realizefn() 2 months ago
cpu-system.c exec: Rename target_words_bigendian() -> target_big_endian() 2 months ago
cpu-user.c cpus: Remove CPUClass::has_work() handler 4 months ago
eif.c hw/core/eif: Use stateful qcrypto apis 7 months ago
eif.h
fw-path-provider.c
generic-loader.c qom: Have class_init() take a const data argument 2 months ago
gpio.c qdev: Use machine_get_container() 6 months ago
guest-loader.c qom: Have class_init() take a const data argument 2 months ago
guest-loader.h
hotplug.c
irq.c hw/irq: Introduce qemu_init_irqs() helper 5 months ago
loader-fit.c include/system: Move exec/memory.h to system/memory.h 2 months ago
loader.c hw/nvram/fw_cfg: Remove legacy FW_CFG_ORDER_OVERRIDE 4 weeks ago
machine-hmp-cmds.c qapi: Move include/qapi/qmp/ to include/qobject/ 5 months ago
machine-qmp-cmds.c qemu: Convert target_name() to TargetInfo API 2 months ago
machine-smp.c i386/cpu: add has_caches flag to check smp_cache configuration 4 months ago
machine.c hw/core/machine: Remove hw_compat_2_5[] array 4 weeks ago
meson.build meson: remove lib{system, user}_ss aliases 1 month ago
nmi.c
null-machine.c include/system: Move exec/address-spaces.h to system/address-spaces.h 2 months ago
numa.c include: Rename sysemu/ -> system/ 6 months ago
or-irq.c qom: Have class_init() take a const data argument 2 months ago
platform-bus.c qom: Have class_init() take a const data argument 2 months ago
ptimer.c include/exec: Split out icount.h 2 months ago
qdev-clock.c
qdev-fw.c
qdev-hotplug.c hw/qdev: Check machine_hotplug_handler in hotplug_unplug_allowed_common 6 months ago
qdev-prop-internal.h
qdev-properties-system.c hw/core/qdev-properties-system: Add missing return in set_drive_helper() 3 weeks ago
qdev-properties.c qdev, rust/hpet: fix type of HPET "timers" property 3 months ago
qdev-user.c qdev: Implement qdev_create_fake_machine() for user emulation 6 months ago
qdev.c qom: Make InterfaceInfo[] uses const 2 months ago
register.c qom: Have class_init() take a const data argument 2 months ago
reset.c qom: Have class_init() take a const data argument 2 months ago
resetcontainer.c qom: Have class_init() take a const data argument 2 months ago
resettable.c
split-irq.c qom: Have class_init() take a const data argument 2 months ago
stream.c
sysbus-fdt.c vfio: Introduce new files for VFIORegion definitions and declarations 2 months ago
sysbus.c qom: Have class_init() take a const data argument 2 months ago
trace-events
trace.h
uboot_image.h
vm-change-state-handler.c system/runstate: add VM state change cb with return value 2 months ago
vmstate-if.c