mirror of https://gitlab.com/qemu-project/qemu
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
77dc9d662f
The linux-test test includes an attempt to check the utime and stat
syscalls by setting the atime and mtime of a file to specific values,
and then calling stat() to check that the values read back correctly.
Unfortunately this is flaky, as it will fail if some other process
(for instance a virus scanner, backup program, etc) gets in and reads
the file between the utime() and stat() call, resulting in a host
syscall sequence like this:
utimensat(AT_FDCWD, "file2",
[{tv_sec=1001, tv_nsec=0} /* 1970-01-01T01:16:41+0100 */,
{tv_sec=1000, tv_nsec=0} /* 1970-01-01T01:16:40+0100 */], 0) = 0
# successfully set atime to 1001 and mtime to 1000
statx(AT_FDCWD, "file2", AT_STATX_SYNC_AS_STAT|AT_NO_AUTOMOUNT,
STATX_BASIC_STATS,
{stx_mask=STATX_BASIC_STATS|STATX_MNT_ID,
stx_blksize=4096, stx_attributes=0, stx_nlink=1, stx_uid=32808,
stx_gid=32808, stx_mode=S_IFREG|0600, stx_ino=21659016,
stx_size=100, stx_blocks=8,
stx_attributes_mask=STATX_ATTR_COMPRESSED|STATX_ATTR_IMMUTABLE|
STATX_ATTR_APPEND|STATX_ATTR_NODUMP|STATX_ATTR_ENCRYPTED|
STATX_ATTR_AUTOMOUNT|STATX_ATTR_MOUNT_ROOT|STATX_ATTR_VERITY|
STATX_ATTR_DAX,
stx_atime={tv_sec=1760091862, tv_nsec=63509009} /* 2025-10-10T11:24:22.063509009+0100 */,
stx_ctime={tv_sec=1760091862, tv_nsec=63509009} /* 2025-10-10T11:24:22.063509009+0100 */,
stx_mtime={tv_sec=1000, tv_nsec=0} /* 1970-01-01T01:16:40+0100 */,
stx_rdev_major=0, stx_rdev_minor=0, stx_dev_major=252,
stx_dev_minor=0, stx_mnt_id=0x1f}) = 0
# but when we statx the file, we get back an mtime of 1000
# but an atime corresponding to when the other process read it
and which will cause the test program to fail with the error
message "stat time".
In theory we could defend against this by e.g. operating on files in
a dummy loopback mount filesystem which we mounted as 'noatime', but
this isn't worth the hassle. Just drop the check on atime.
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20251016150357.876415-4-alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
|
3 days ago | |
|---|---|---|
| .. | ||
| arm-compat-semi | 2 years ago | |
| gdbstub | 1 month ago | |
| libs | 2 years ago | |
| linux | 3 days ago | |
| system | 3 months ago | |
| Makefile.target | 4 weeks ago | |
| README | ||
| catch-syscalls.c | 2 years ago | |
| check-plugin-output.sh | 1 year ago | |
| float_convd.c | 2 years ago | |
| float_convs.c | 2 years ago | |
| float_helpers.h | 2 years ago | |
| float_madds.c | 2 years ago | |
| fnmsub.c | 4 months ago | |
| follow-fork-mode.c | 2 years ago | |
| late-attach.c | 9 months ago | |
| munmap-pthread.c | 3 years ago | |
| noexec.c.inc | 3 years ago | |
| nop_func.h | 3 years ago | |
| overflow.c | 3 years ago | |
| prot-none.c | 2 years ago | |
| segfault.c | 2 years ago | |
| sha1.c | 4 years ago | |
| sha512.c | 2 years ago | |
| sigbus.c | 2 years ago | |
| signals.c | 4 years ago | |
| sigreturn-sigmask.c | 11 months ago | |
| tb-link.c | 4 weeks ago | |
| test-aes-main.c.inc | 2 years ago | |
| test-mmap.c | 4 years ago | |
| test-plugin-mem-access.c | 1 year ago | |
| testthread.c | ||
| threadcount.c | 5 years ago | |
| vma-pthread.c | 3 years ago | |
README
Multi-architecture linux-user tests