You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/monitor
Andrey Drobyshev 03f50d7ee7 monitor: don't wake up qmp_dispatcher_co coroutine upon cleanup
Since the commit 3e6bed61 ("monitor: cleanup detection of qmp_dispatcher_co
shutting down"), coroutine pointer qmp_dispatcher_co is set to NULL upon
cleanup.  If a QMP command is sent after monitor_cleanup() (e.g. after
shutdown), this may lead to SEGFAULT on aio_co_wake(NULL).

As mentioned in the comment inside monitor_cleanup(), the intention is to
allow incoming requests while shutting down, but simply leave them
without any response.  Let's do exactly that, and if qmp_dispatcher_co
coroutine pointer has already been set to NULL, let's simply skip the
aio_co_wake() part.

Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Link: https://lore.kernel.org/r/20250502214729.928380-2-andrey.drobyshev@virtuozzo.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 month ago
..
fds.c include: Rename sysemu/ -> system/ 6 months ago
hmp-cmds-target.c exec/cpu-all: remove exec/target_page include 1 month ago
hmp-cmds.c include/system: Move exec/ioport.h to system/ioport.h 2 months ago
hmp-target.c include: Rename sysemu/ -> system/ 6 months ago
hmp.c qapi: Move include/qapi/qmp/ to include/qobject/ 4 months ago
meson.build util/qemu-config: Extract QMP commands to qemu-config-qmp.c 1 year ago
monitor-internal.h qapi: Move and rename qapi/qmp/dispatch.h to qapi/qmp-registry.h 4 months ago
monitor.c qapi: Move include/qapi/qmp/ to include/qobject/ 4 months ago
qemu-config-qmp.c qapi: Move include/qapi/qmp/ to include/qobject/ 4 months ago
qmp-cmds-control.c include: Rename sysemu/ -> system/ 6 months ago
qmp-cmds.c migration/block: Rewrite disk activation 5 months ago
qmp.c monitor: don't wake up qmp_dispatcher_co coroutine upon cleanup 1 month ago
trace-events docs: fix references to docs/devel/tracing.rst 4 years ago
trace.h trace: switch position of headers to what Meson requires 5 years ago