You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/io
Peter Xu 7e0c22d585 io/crypto: Move tls premature termination handling into QIO layer
QCryptoTLSSession allows TLS premature termination in two cases, one of the
case is when the channel shutdown() is invoked on READ side.

It's possible the shutdown() happened after the read thread blocked at
gnutls_record_recv().  In this case, we should allow the premature
termination to happen.

The problem is by the time qcrypto_tls_session_read() was invoked,
tioc->shutdown may not have been set, so this may instead be treated as an
error if there is concurrent shutdown() calls.

To allow the flag to reflect the latest status of tioc->shutdown, move the
check upper into the QIOChannel level, so as to read the flag only after
QEMU gets an GNUTLS_E_PREMATURE_TERMINATION.

When at it, introduce qio_channel_tls_allow_premature_termination() helper
to make the condition checks easier to read.  When doing so, change the
qatomic_load_acquire() to qatomic_read(): here we don't need any ordering
of memory accesses, but reading a flag.  qatomic_read() would suffice
because it guarantees fetching from memory.  Nothing else we should need to
order on memory access.

This patch will fix a qemu qtest warning when running the preempt tls test,
reporting premature termination:

QTEST_QEMU_BINARY=./qemu-system-x86_64 ./tests/qtest/migration-test --full -r /x86_64/migration/postcopy/preempt/tls/psk
...
qemu-kvm: Cannot read from TLS channel: The TLS connection was non-properly terminated.
...

In this specific case, the error was set by postcopy_preempt_thread, which
normally will be concurrently shutdown()ed by the main thread.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juraj Marcin <jmarcin@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20250918203937.200833-2-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
3 weeks ago
..
channel-buffer.c qom: Have class_init() take a const data argument 6 months ago
channel-command.c treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking 1 month ago
channel-file.c treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking 1 month ago
channel-null.c qom: Have class_init() take a const data argument 6 months ago
channel-socket.c error: Kill @error_warn 3 weeks ago
channel-tls.c io/crypto: Move tls premature termination handling into QIO layer 3 weeks ago
channel-util.c io: follow coroutine AioContext in qio_channel_yield() 2 years ago
channel-watch.c error: Kill @error_warn 3 weeks ago
channel-websock.c treewide: handle result of qio_channel_set_blocking() 1 month ago
channel.c treewide: handle result of qio_channel_set_blocking() 1 month ago
dns-resolver.c io: Fix partial struct copy in qio_dns_resolver_lookup_sync_inet() 5 months ago
meson.build Revert "meson: Propagate gnutls dependency" 1 year ago
net-listener.c io: Stop appending -listen to net listeners 2 years ago
task.c io: Fix Lesser GPL version number 5 years ago
trace-events io: tls: Add qio_channel_tls_bye 8 months ago
trace.h trace: switch position of headers to what Meson requires 5 years ago