You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/include/hw/sd
Peter Maydell 77dd098a5e hw/sd/omap_mmc: Don't use sd_cmd_type_t
In commit 1ab08790bb we did some refactoring of the SD card
implementation, which included a rearrangement of the sd_cmd_type_t
enum values.  Unfortunately we didn't notice that this enum is not
used solely inside the SD card model itself, but is also used by the
OMAP MMC controller device.  In the OMAP MMC controller, it is used
to implement the handling of the Type field of the MMC_CMD register,
so changing the enum values so that they no longer lined up with the
bit definitions for that register field broke the controller model.
The effect is that Linux fails to boot from an SD card on the "sx1"
machine.

Give omap-mmc its own enum which we can document as needing to match
the encoding used in this device's register, so it isn't sharing
sd_cmd_type_t with the SD card model any more.  We can then move
sd_cmd_type_t's definition out of sd.h and into sd.c, which is the
only place that uses it.

Cc: qemu-stable@nongnu.org
Fixes: 1ab08790bb ("hw/sd/sdcard: Store command type in SDProto")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20241017162755.710698-1-peter.maydell@linaro.org
1 month ago
..
allwinner-sdhost.h hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support 2 years ago
aspeed_sdhci.h Fix SPDX-License-Identifier typos 4 years ago
bcm2835_sdhost.h Use OBJECT_DECLARE_SIMPLE_TYPE when possible 4 years ago
cadence_sdhci.h hw/sd: Add Cadence SDHCI emulation 4 years ago
npcm7xx_sdhci.h hw/arm/npcm7xx: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE() 2 years ago
sd.h hw/sd/omap_mmc: Don't use sd_cmd_type_t 1 month ago
sdcard_legacy.h hw/sd: Rename read/write_data() as read/write_byte() 4 years ago
sdhci.h include/hw/pci: Split pci_device.h off pci.h 2 years ago