mirror of https://gitlab.com/qemu-project/qemu
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ef44cc0a76
msix_init() and msix_init_exclusive_bar() take an "unsigned short" argument for the number of MSI-X vectors to try to use. This is big enough for the maximum permitted number of vectors, which is 2048. Unfortunately, we have several devices (most notably virtio) which allow the user to specify the desired number of vectors, and which use uint32_t properties for this. If the user sets the property to a value that is too big for a uint16_t, the value will be truncated when it is passed to msix_init(), and msix_init() may then return success if the truncated value is a valid one. The resulting mismatch between the number of vectors the msix code thinks the device has and the number of vectors the device itself thinks it has can cause assertions, such as the one in issue 2631, where "-device virtio-mouse-pci,vectors=19923041" is interpreted by msix as "97 vectors" and by the virtio-pci layer as "19923041 vectors"; a guest attempt to access vector 97 thus passes the virtio-pci bounds checking and hits an essertion in msix_vector_use(). Avoid this by making msix_init() and its wrapper function msix_init_exclusive_bar() take the number of vectors as a uint32_t. The erroneous command line will now produce the warning qemu-system-i386: -device virtio-mouse-pci,vectors=19923041: warning: unable to init msix vectors to 19923041 and proceed without crashing. (The virtio device warns and falls back to not using MSIX, rather than complaining that the option is not a valid value this is the same as the existing behaviour for values that are beyond the MSI-X maximum possible value but fit into a 16-bit integer, like 2049.) To ensure this doesn't result in potential overflows in calculation of the BAR size in msix_init_exclusive_bar(), we duplicate the nentries error-check from msix_init() at the top of msix_init_exclusive_bar(), so we know nentries is sane before we start using it. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2631 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20251107131044.1321637-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> |
1 week ago | |
|---|---|---|
| .. | ||
| Kconfig | 2 years ago | |
| meson.build | 2 years ago | |
| msi.c | 12 months ago | |
| msix.c | 1 week ago | |
| pci-hmp-cmds.c | 10 months ago | |
| pci-internal.h | 3 years ago | |
| pci-qmp-cmds.c | 3 years ago | |
| pci-stub.c | 1 year ago | |
| pci.c | 1 month ago | |
| pci_bridge.c | 7 months ago | |
| pci_host.c | 7 months ago | |
| pcie.c | 2 months ago | |
| pcie_aer.c | 2 years ago | |
| pcie_doe.c | 3 years ago | |
| pcie_host.c | 3 years ago | |
| pcie_port.c | 7 months ago | |
| pcie_sriov.c | 2 months ago | |
| shpc.c | 2 years ago | |
| slotid_cap.c | 3 years ago | |
| trace-events | 7 months ago | |
| trace.h | 5 years ago | |