You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/hw/isa
Igor Mammedov b10166b104 x86: ich9: fix default value of 'No Reboot' bit in GCS
[2] initialized 'No Reboot' bit to 1 by default. And due to quirk it happened
to work with linux iTCO_wdt driver (which clears it on module load).

However spec [1] states:
"
R/W. This bit is set when the “No Reboot” strap (SPKR pin on
ICH9) is sampled high on PWROK.
"

So it should be set only when  '-global ICH9-LPC.noreboot=true' and cleared
when it's false (which should be default).

Fix it to behave according to spec and set 'No Reboot' bit only when
'-global ICH9-LPC.noreboot=true'.

1)
Intel I/O Controller Hub 9 (ICH9) Family Datasheet (rev: 004)
2)

Fixes: 920557971b (ich9: add TCO interface emulation)
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20250922132600.562193-1-imammedo@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
3 weeks ago
..
Kconfig hw/isa: extract FDC37M81X to a separate file 2 years ago
apm.c hw/isa: Constify VMState 2 years ago
fdc37m81x-superio.c qom: Have class_init() take a const data argument 6 months ago
i82378.c qom: Make InterfaceInfo[] uses const 6 months ago
isa-bus.c qom: Have class_init() take a const data argument 6 months ago
isa-superio.c hw/isa/superio: Include 'system/system.h' 2 months ago
lpc_ich9.c x86: ich9: fix default value of 'No Reboot' bit in GCS 3 weeks ago
meson.build hw/isa/meson.build: Sort alphabetically 2 years ago
pc87312.c qom: Have class_init() take a const data argument 6 months ago
piix.c qom: Make InterfaceInfo[] uses const 6 months ago
smc37c669-superio.c qom: Have class_init() take a const data argument 6 months ago
trace-events hw/audio/via-ac97: Basic implementation of audio playback 3 years ago
trace.h trace: switch position of headers to what Meson requires 5 years ago
vt82c686.c qom: Make InterfaceInfo[] uses const 6 months ago