You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qemu/hw/i386
Mark Cave-Ayland e502e614f4 hw/i386/pc_piix.c: remove unnecessary if() from pc_init1()
Now that the isapc logic has been split out of pc_piix.c, the PCI Host Bridge
(phb) object is now always set in pc_init1().

Since phb is now guaranteed not to be NULL, Coverity reports that the if()
statement surrounding ioapic_init_gsi() is now unnecessary and can be removed
along with the phb NULL initialiser.

Coverity: CID 1620557
Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Fixes: 99d0630a45 ("hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in pc_init1()")
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250901203409.1196620-1-mark.caveayland@nutanix.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
6 days ago
..
kvm * target/i386/kvm: Intel TDX support 3 months ago
xen qom: Make InterfaceInfo[] uses const 5 months ago
Kconfig hw/i386: move isapc machine to separate isapc.c file 1 week ago
acpi-build.c hw/i386/acpi-build: Move aml_pci_edsm to a generic place 2 months ago
acpi-build.h hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp 2 months ago
acpi-common.c include/system: Move exec/memory.h to system/memory.h 5 months ago
acpi-common.h hw/i386/acpi: Declare pc_madt_cpu_entry() in 'acpi-common.h' 2 years ago
acpi-microvm.c include/system: Move exec/memory.h to system/memory.h 5 months ago
acpi-microvm.h microvm/acpi: add minimal acpi support 5 years ago
amd_iommu-stub.c amd_iommu: report x2APIC support to the operating system 2 years ago
amd_iommu.c hw/i386/amd_iommu: Fix event log generation 1 month ago
amd_iommu.h hw/i386/amd_iommu: Fix event log generation 1 month ago
e820_memory_layout.c hw/i386/fw_cfg: Add etc/e820 to fw_cfg late 1 year ago
e820_memory_layout.h hw/i386/fw_cfg: Add etc/e820 to fw_cfg late 1 year ago
fw_cfg.c rust: Kconfig: Factor out whether HPET is Rust or C 6 months ago
fw_cfg.h hw/i386/fw_cfg: Add etc/e820 to fw_cfg late 1 year ago
intel_iommu.c intel_iommu: Allow both Status Write and Interrupt Flag in QI wait 1 month ago
intel_iommu_internal.h intel_iommu: Declare supported PASID size 2 months ago
isapc.c hw/i386/isapc.c: replace rom_memory with system_memory 1 week ago
meson.build hw/i386: move isapc machine to separate isapc.c file 1 week ago
microvm-dt.c include: Rename sysemu/ -> system/ 9 months ago
microvm-dt.h microvm: add device tree support. 4 years ago
microvm.c hw/i386: Fix 'use-legacy-x86-rom' property compatibility 1 month ago
monitor.c qapi: expose rtc-reset-reinjection command unconditionally 3 months ago
multiboot.c exec/cpu-all: remove exec/target_page include 5 months ago
multiboot.h target/i386: use DMA-enabled multiboot ROM for new-enough QEMU machine types 4 years ago
nitro_enclave.c qom: Have class_init() take a const data argument 5 months ago
pc.c hw: add compat machines for 10.2 2 weeks ago
pc_piix.c hw/i386/pc_piix.c: remove unnecessary if() from pc_init1() 6 days ago
pc_q35.c hw: add compat machines for 10.2 2 weeks ago
pc_sysfw.c i386/pc_sysfw: Ensure sysfw flash configuration does not conflict with IGVM 2 months ago
pc_sysfw_ovmf-stubs.c hw/i386: Introduce X86_FW_OVMF Kconfig symbol 4 years ago
pc_sysfw_ovmf.c exec/cpu-all: remove exec/target_page include 5 months ago
port92.c qom: Have class_init() take a const data argument 5 months ago
sgx-epc.c qom: Make InterfaceInfo[] uses const 5 months ago
sgx-stub.c qapi: make SGX commands unconditionally available 3 months ago
sgx.c qapi: make SGX commands unconditionally available 3 months ago
tdvf-hob.c i386/tdx: Setup the TD HOB list 3 months ago
tdvf-hob.h i386/tdx: Setup the TD HOB list 3 months ago
tdvf.c i386/tdvf: Fix build on 32-bit host 3 months ago
trace-events hw/i386/intel-iommu: Migrate to 3-phase reset 7 months ago
trace.h trace: switch position of headers to what Meson requires 5 years ago
vapic.c qom: Have class_init() take a const data argument 5 months ago
vmmouse.c qom: Have class_init() take a const data argument 5 months ago
vmport.c qom: Have class_init() take a const data argument 5 months ago
x86-common.c x86/loader: Don't update kernel header for CoCo VMs 2 weeks ago
x86-cpu.c include: Rename sysemu/ -> system/ 9 months ago
x86-iommu-stub.c hw/i386/pc: Remove x86_iommu_get_type() 4 years ago
x86-iommu.c qom: Have class_init() take a const data argument 5 months ago
x86.c hw/i386/x86: Remove X86MachineClass::save_tsc_khz field 3 months ago